[webkit-reviews] review requested: [Bug 20119] Execute CSS Animations : [Attachment 22437] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 22 16:40:23 PDT 2008

Dean Jackson <dino at apple.com> has asked Dave Hyatt <hyatt at apple.com> for
Bug 20119: Execute CSS Animations

Attachment 22437: Updated patch

------- Additional Comments from Dean Jackson <dino at apple.com>
This update fixes the assertion that we hit when unloading a page with running
animations. I'd like feedback on the fix because I'm sure there is a better way
to do it. This patch marks a document as it is being unloaded so that the style
is not recalculated (the animation engine had marked the document as changed),
and marks it loaded as it comes back from history. It would be better if the
updateRendering is never called, but it seems to happen from multiple places.

More information about the webkit-reviews mailing list