[webkit-reviews] review granted: [Bug 20056] [XBL] XBLCachedDocument cleanup : [Attachment 22309] Proposed cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 22 08:37:20 PDT 2008

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 20056: [XBL] XBLCachedDocument cleanup

Attachment 22309: Proposed cleanup

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think:
5	  RefPtr<WebCore::XBLDocument> document() const { return m_document; }

Should probably return PassRefPtr, no?	PassRefPtr will automatically copy from
RefPtr in this case, but there will be no additional ref churn on assignment. 
Otherwise looks fine.

More information about the webkit-reviews mailing list