[webkit-reviews] review denied: [Bug 19588] CRASH doing open() on destroyed window : [Attachment 22415] Proposed fix: add null check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 22 08:33:00 PDT 2008


Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 19588: CRASH doing open() on destroyed window
https://bugs.webkit.org/show_bug.cgi?id=19588

Attachment 22415: Proposed fix: add null check
https://bugs.webkit.org/attachment.cgi?id=22415&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why shouldn't you just use "top()" here?  It seems "top()" wouldn't crash.

Seems like the end of the function doesn't check against null pages either...
so that will need to be fixed and a test case added too.


More information about the webkit-reviews mailing list