[webkit-reviews] review denied: [Bug 19919] Add selectors' string parsing in CSSParser : [Attachment 22297] Same as the previous one, without the memory leak

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 21 16:43:27 PDT 2008


Sam Weinig <sam at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 19919: Add selectors' string parsing in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=19919

Attachment 22297: Same as the previous one, without the memory leak
https://bugs.webkit.org/attachment.cgi?id=22297&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
Sorry for leading you down a bad path, but I think a better and less invasive
would to be just to return an auto_ptr and not turn CSSSelector into a
RefCounted object.


More information about the webkit-reviews mailing list