[webkit-reviews] review granted: [Bug 20121] Cleanup of FrameLoader load() in a move towards sanity : [Attachment 22399] Updated patch to eliminate some stray tab characters, fix a typo.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Daniel Jalkut
<jalkut at red-sweater.com>'s request for review:
Bug 20121: Cleanup of FrameLoader load() in a move towards sanity
https://bugs.webkit.org/show_bug.cgi?id=20121

Attachment 22399: Updated patch to eliminate some stray tab characters, fix a
typo.
https://bugs.webkit.org/attachment.cgi?id=22399&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Just to give you some background, all these "load" methods came about when we
merged the loader code, which had been sprinkled throughout WebCore and WebKit,
into a single WebCore class. The merge illuminated a spaghetti-like structure
(perhaps an image of the holy flying spaghetti monster itself?!) of similarly
named and purposed functions. At the time, we named all such functions "load"
as a way of saying, "We should probably refactor this code, removing and/or
merging redundant noodley appendages, when we get a chance."

Anyway, I think your renames improve clarity, so I'll say "r+", but an even
better solution would refactor the loader and eliminate some of these functions
altogether.