[webkit-reviews] review cancelled: [Bug 15979] Console logs in a database callback lose line number information : [Attachment 22387] Fix exception handling in the many places it wasn't correct.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 20 05:44:15 PDT 2008
Oliver Hunt <oliver at apple.com> has cancelled Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 15979: Console logs in a database callback lose line number information
https://bugs.webkit.org/show_bug.cgi?id=15979
Attachment 22387: Fix exception handling in the many places it wasn't correct.
https://bugs.webkit.org/attachment.cgi?id=22387&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
Mark reviewed, and requested a few changes.
Committing to http://svn.webkit.org/repository/webkit/trunk ...
M LayoutTests/ChangeLog
M
LayoutTests/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt
A LayoutTests/fast/js/exceptions-thrown-in-callbacks-expected.txt
A LayoutTests/fast/js/exceptions-thrown-in-callbacks.html
M LayoutTests/fast/xpath/nsresolver-exception-expected.txt
M LayoutTests/fast/xsl/transform-xhr-doc-expected.txt
M
LayoutTests/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-
write-expected.txt
M
LayoutTests/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascrip
t-url-expected.txt
M
LayoutTests/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt
M LayoutTests/platform/mac/fast/dynamic/015-expected.txt
M
LayoutTests/platform/mac/fast/events/updateLayoutForHitTest-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92868_1-expec
ted.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/appendCells1-expe
cted.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/appendCellsRebuil
d1-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/insertTbodyExpand
1-expected.txt
M
LayoutTests/platform/mac/tables/mozilla_expected_failures/dom/insertTbodyRebuil
d1-expected.txt
M
LayoutTests/storage/transaction_callback_exception_crash-expected.txt
M WebCore/ChangeLog
M WebCore/bindings/js/JSCustomSQLStatementCallback.cpp
M WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp
M WebCore/bindings/js/JSCustomSQLTransactionCallback.cpp
M WebCore/bindings/js/JSCustomSQLTransactionErrorCallback.cpp
M WebCore/bindings/js/JSCustomVoidCallback.cpp
M WebCore/bindings/js/JSCustomXPathNSResolver.cpp
M WebCore/bindings/js/JSEventListener.cpp
M WebCore/bindings/js/ScheduledAction.cpp
M WebCore/bindings/js/ScriptController.cpp
M WebCore/bindings/objc/WebScriptObject.mm
M WebCore/page/Console.cpp
M WebCore/page/Console.h
Committed r35253
More information about the webkit-reviews
mailing list