[webkit-reviews] review requested: [Bug 20029] [XBL] Add more tags : [Attachment 22371] Patch updated with Eric's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 18 12:27:36 PDT 2008

Julien Chaffraix <jchaffraix at webkit.org> has asked  for review:
Bug 20029: [XBL] Add more tags

Attachment 22371: Patch updated with Eric's comments

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
(In reply to comment #11)
> (From update of attachment 22341 [edit])
> xblCustomMappings shouldn't be needed.  HTML will need this too.  This should

> just be a property of the tag in the .in file.

I thought it would interact badly with the .in file format change discussed on
the ML that I intend to do (thus my original FIXME). However after thinking
about it, I guess I could add just one property without too much trouble.

> Also, I don't think you need a comment about <div> in the XBLElement header. 

> XBLElements probably want to be StyledElements anyway.  I mean, it's also
> possible to just create an empty XBLDivElement, despite hyatt's suggestions
> the contrary.  The cost in terms of code and binary size are negligible.

HTMLElement also derives from StyledElement so we could do the same here too.

> I think you should make the "generate w/o having a custom class" thing work
> though, since our first pass in converting HTMLElementFactory will use that.

It should work.

More information about the webkit-reviews mailing list