[webkit-reviews] review requested: [Bug 18774] SQUIRRELFISH: print meaningful error messages : [Attachment 22359] Patch o' doom

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 18774: SQUIRRELFISH: print meaningful error messages
https://bugs.webkit.org/show_bug.cgi?id=18774

Attachment 22359: Patch o' doom
https://bugs.webkit.org/attachment.cgi?id=22359&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Here we go, error messages that Do Not Suck (tm)

A few issues -- I haven't yet fixed all the error messages so some,
particularly syntax errors, still do not produce awe inspiring messages, but
hey have all the information required to do so.

All the standard errors are now good and wonderful, and all have the additional
character position information attached.

The error messages are currently of the form
> undefined.b++
TypeError: Result of expression 'undefined' [undefined] is not an object.
> undefined[0]
TypeError: Result of expression 'undefined' [undefined] is not an object.
> undefined()
TypeError: Result of expression 'undefined' [undefined] is not a function.
> new undefined()
TypeError: Result of expression 'undefined' [undefined] is not a constructor.
> 1 in undefined
TypeError: Result of expression 'undefined' [undefined] is not a valid argument
for 'in'.
> 1 instanceof undefined
TypeError: Result of expression 'undefined' [undefined] is not a valid argument
for 'instanceof'.
>