[webkit-reviews] review denied: [Bug 20029] [XBL] Add more tags : [Attachment 22341] Updated: add <binding>, template> and <div> but do not create XBLDivElement class

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 20029: [XBL] Add more tags
https://bugs.webkit.org/show_bug.cgi?id=20029

Attachment 22341: Updated: add <binding>, template> and <div> but do not create
XBLDivElement class
https://bugs.webkit.org/attachment.cgi?id=22341&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
xblCustomMappings shouldn't be needed.	HTML will need this too.  This should
just be a property of the tag in the .in file.

Also, I don't think you need a comment about <div> in the XBLElement header. 
XBLElements probably want to be StyledElements anyway.	I mean, it's also
possible to just create an empty XBLDivElement, despite hyatt's suggestions to
the contrary.  The cost in terms of code and binary size are negligible.

I think you should make the "generate w/o having a custom class" thing work
though, since our first pass in converting HTMLElementFactory will use that.