[webkit-reviews] review granted: [Bug 19912] stl::* symbols unexpectedly exported : [Attachment 22106] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 17 09:41:27 PDT 2008

Holger Freyther <freyther at handhelds.org> has granted Mike Hommey
<mh+webkit at glandium.org>'s request for review:
Bug 19912: stl::* symbols unexpectedly exported

Attachment 22106: patch

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Okay. We don't have a coding style for these kind of files but wouldn't it be
more obvious if _ZSt*; and _ZNSt*; would be in the same line as local? or at
least indented?

What do you think about the following (less conservative) change?

global: webkit_*;
local: *;

besides I wonder if people use WebKit without the GNU or sun linker.

More information about the webkit-reviews mailing list