[webkit-reviews] review requested: [Bug 20065] Remove UChar* accessors from StringImpl : [Attachment 22340] First attempt, push logic from String.cpp into StringImpl.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 17 09:27:01 PDT 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 20065: Remove UChar* accessors from StringImpl
https://bugs.webkit.org/show_bug.cgi?id=20065

Attachment 22340: First attempt, push logic from String.cpp into StringImpl.cpp
https://bugs.webkit.org/attachment.cgi?id=22340&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 WebCore/ChangeLog			|   26 ++++++++
 WebCore/platform/text/PlatformString.h |    2 +
 WebCore/platform/text/String.cpp	|   79 ++++++-------------------
 WebCore/platform/text/StringImpl.cpp	|  104 +++++++++++++++++++++++++++++---
 WebCore/platform/text/StringImpl.h	|   12 ++++-
 5 files changed, 153 insertions(+), 70 deletions(-)


More information about the webkit-reviews mailing list