[webkit-reviews] review granted: [Bug 20061] Optimize array accesses with constant indices. : [Attachment 22319] Patch v1, adds op_get_by_index, optimizes array access with constant indices.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 16 22:50:29 PDT 2008


Oliver Hunt <oliver at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 20061: Optimize array accesses with constant indices.
https://bugs.webkit.org/show_bug.cgi?id=20061

Attachment 22319: Patch v1, adds op_get_by_index, optimizes array access with
constant indices.
https://bugs.webkit.org/attachment.cgi?id=22319&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Minor style issues:
  the if in BracketAccessorNode::emitCode is a single line so should not have
braces
  ditto for FunctionCallBracketNode::emitCode, ForInNode::emitCode
  The else blocks in PostIncBracketNode::emitCode are single line, so shouldn't
have braces
 
Other than those this looks good. r=me.


More information about the webkit-reviews mailing list