[webkit-reviews] review granted: [Bug 10745] SVGLength object needs some weight loss : [Attachment 22318] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 16 15:27:46 PDT 2008

Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 10745: SVGLength object needs some weight loss

Attachment 22318: Updated patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good.

Unfortunately if these are allocated on the heap this won't actually save
memory (due to 16 byte alignment), however if SVGLength is ever used as a
member, the owning object will shrink by 4 bytes. :)

Looks good though.

Could you please explain the results of:

$getterContentHead = "IMPL->value(0 /* FIXME */";

Perhaps you could even add a failing test for these two /* FIXME */ cases?

More information about the webkit-reviews mailing list