[webkit-reviews] review denied: [Bug 19045] [gtk] ./configure doesn't check for x toolkit availability : [Attachment 22029] Updated: Suggested change to configure.ac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 16 10:55:53 PDT 2008


Holger Freyther <freyther at handhelds.org> has denied Dominik Röttsches
<dominik.roettsches at access-company.com>'s request for review:
Bug 19045: [gtk] ./configure doesn't check for x toolkit availability
https://bugs.webkit.org/show_bug.cgi?id=19045

Attachment 22029: Updated: Suggested change to configure.ac
https://bugs.webkit.org/attachment.cgi?id=22029&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
There are some issues with this patch:
  - xt is a X11 library and we only need it if we have TARGET_X11 set. So a
directFB build should not fail with missing xt..

  - gtk2xtbin.c is using xt, we should link to libxt directly. So please change
WebCore/GNUmakefile.am to link to xt?


More information about the webkit-reviews mailing list