[webkit-reviews] review denied: [Bug 17589] Scroll wheel sensitivity ignored : [Attachment 22075] correctd patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 14 10:37:14 PDT 2008

Eric Seidel <eric at webkit.org> has denied Maxime Britto <britto at apple.com>'s
request for review:
Bug 17589: Scroll wheel sensitivity ignored

Attachment 22075: correctd patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
The deltaX clause is incorrect.  Copy/paste bug.  Horizontal scroll events will
cause vertical scrolling.

We talked over IRC about possibly abstracting these scroll + accept clauses
into some nice static inline function(s).

Even stuff like this I would almost consider abstracting:

if (e.isPageXScrollModeEnabled())
+	     deltaX = (deltaX > 0 ? visibleWidth() : -visibleWidth()) /

adjustDeltaForPageScrollMode(deltaX, e.isPageScrollModeEnabled(),

static inline adjustDeltaForPageScrollMode(int& delta, bool
pageScrollModeEnabled, int pageScroll)
  if (pageScrollModeEnabled)
	  delta = (delta > 0 ? pageScroll) : -pageScroll) / LINE_STEP_WIN;

But that is probably not worth it.  Just depends on your copy/paste code
tolerance level... mine is extremely low in general. :)

is there any way we can test this with DRT?

We can fake scroll events, no?	The question would be getting the system
settings to be the same on all machines...  or maybe DRT could hook in some
special way to override the page scroll settings?

r- for the copy/paste error.

More information about the webkit-reviews mailing list