[webkit-reviews] review denied: [Bug 19391] Dynamically created SVG script tags fail to execute : [Attachment 22258] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 12 14:40:38 PDT 2008

Oliver Hunt <oliver at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 19391: Dynamically created SVG script tags fail to execute

Attachment 22258: First attempt

------- Additional Comments from Oliver Hunt <oliver at apple.com>
One observation: SVGScriptElement::evaluateScript has commented out code.

However i don't believe this is correct in all cases.  the HTMLScriptElement
has logic to prevent a script from being executed multiple times when attached
and detached.

I'm wondering if it's worth making a ScriptElement class that has all the logic
to handle attah/detach/execution, etc, although that will require multiple
inheritance which will be yuck

and may screw html performance :-/

More information about the webkit-reviews mailing list