[webkit-reviews] review denied: [Bug 19965] @mediaall recognized as @media all rather than as a generic (unrecognized ATKEYWORD) : [Attachment 22245] Updated patch to use "@"{ident}, updated ChangeLog and added test case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 11 13:07:09 PDT 2008
Rob Buis <rwlbuis at gmail.com> has denied Jacob Refstrup
<jacob.refstrup at hp.com>'s request for review:
Bug 19965: @mediaall recognized as @media all rather than as a generic
(unrecognized ATKEYWORD)
https://bugs.webkit.org/show_bug.cgi?id=19965
Attachment 22245: Updated patch to use "@"{ident}, updated ChangeLog and added
test case
https://bugs.webkit.org/attachment.cgi?id=22245&action=edit
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
You need to include layout test ChangeLog and results too. Maybe you can use
dumpAsText to avoid the pixel test.
Are there no regressions?
Why the yellow background? Can't you just use white or not set the background?
More information about the webkit-reviews
mailing list