[webkit-reviews] review denied: [Bug 19975] [OpenBSD] Patches to enable build of WebKit : [Attachment 22246] new patch to correctly include pthread.h

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied 's request for review:
Bug 19975: [OpenBSD] Patches to enable build of WebKit
https://bugs.webkit.org/show_bug.cgi?id=19975

Attachment 22246: new patch to correctly include pthread.h
https://bugs.webkit.org/attachment.cgi?id=22246&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>--- JavaScriptCore/kjs/collector.cpp.orig	Mon Jun 16 01:40:06 2008
>+++ JavaScriptCore/kjs/collector.cpp	Fri Jul 11 11:46:16 2008
>@@ -61,6 +61,10 @@
> #include <thread.h>
> #endif
> 
>+#if PLATFORM(OPENBSD)
>+#include <pthread.h>
>+#endif
>+
> #if HAVE(PTHREAD_NP_H)
> #include <pthread_np.h>
> #else

Looks good.

>@@ -331,6 +335,11 @@ static inline void* currentThreadStackBase()
>     stack_t s;
>     thr_stksegment(&s);
>     return s.ss_sp;
>+#elif PLATFORM(OPENBSD)
>+    pthread_t thread = pthread_self();
>+    stack_t stack;
>+    pthread_stackseg_np(thread, &stack);
>+    return stack.ss_sp;
> #elif PLATFORM(UNIX)
>     static void* stackBase = 0;
>     static size_t stackSize = 0;

This is already in the first patch.  There's no need to include it here.

The ChangeLog for the first patch is "free".  Please create one using the
prepare-ChangeLog script.  Thanks!

r- for above issues.