[webkit-reviews] review requested: [Bug 19965] @mediaall recognized as @media all rather than as a generic (unrecognized ATKEYWORD) : [Attachment 22245] Updated patch to use "@"{ident}, updated ChangeLog and added test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 11 01:46:06 PDT 2008


Jacob Refstrup <jacob.refstrup at hp.com> has asked  for review:
Bug 19965: @mediaall recognized as @media all rather than as a generic
(unrecognized ATKEYWORD)
https://bugs.webkit.org/show_bug.cgi?id=19965

Attachment 22245: Updated patch to use "@"{ident}, updated ChangeLog and added
test case 
https://bugs.webkit.org/attachment.cgi?id=22245&action=edit

------- Additional Comments from Jacob Refstrup <jacob.refstrup at hp.com>
Changed the fix to use "@"{ident} to return ATKEYWORD to be closer to the
CSS2.1 spec. The '@' by itself (without a following identifier) should per
CSS2.1 not be used in error recovery rules the same place that the ATKEYWORD is
used. 

In practice this doesn't change error recovery as the invalid_block and
invalid_block_list are used in all productions that need error recovery.


More information about the webkit-reviews mailing list