[webkit-reviews] review granted: [Bug 19978] GTK port always ends up with # at the end of resource URLs (and hence can't load files) : [Attachment 22206] KURL::clearRef added and used to fix situation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 10 15:45:06 PDT 2008
Darin Adler <darin at apple.com> has granted Jacob Refstrup
<jacob.refstrup at hp.com>'s request for review:
Bug 19978: GTK port always ends up with # at the end of resource URLs (and
hence can't load files)
https://bugs.webkit.org/show_bug.cgi?id=19978
Attachment 22206: KURL::clearRef added and used to fix situation
https://bugs.webkit.org/attachment.cgi?id=22206&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
The ChangeLog has tab characters in it. That will make it impossible to check
in as is. Otherwise, this looks good.
We should take a look at other callers of setRef and see if any should be
changed to use this new function. Perhaps the function should be called
removeRef instead of clearRef.
I think this patch is good enough as-is that I will say r=me
More information about the webkit-reviews
mailing list