[webkit-reviews] review denied: [Bug 19867] Inspector should support $(id) in the command line : [Attachment 22127] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 10 08:12:22 PDT 2008

Adam Roben (aroben) <aroben at apple.com> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19867: Inspector should support $(id) in the command line

Attachment 22127: patch

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+	 expression = "with (testAPI) { " + expression + " }";

I think using with like this will change the meaning of "this" in the user's
expression. It should be pretty easy to test this. We definitely don't want to
change "this"!

It looks like Firebug uses window.__scope__, which I assume is a
Mozilla-specific extension. Maybe Geoff Garen would have some ideas about how
best to accomplish this.

More information about the webkit-reviews mailing list