[webkit-reviews] review requested: [Bug 18540] console.log('multiple', 'strings') quotes all strings after the first : [Attachment 22197] fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 10 01:07:05 PDT 2008


Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 18540: console.log('multiple', 'strings') quotes all strings after the
first
https://bugs.webkit.org/show_bug.cgi?id=18540

Attachment 22197: fix
https://bugs.webkit.org/attachment.cgi?id=22197&action=edit

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
Should I have written
    Object.type(parameters[i], InspectorController.inspectedWindow()) ===
"string"
instead of
    typeof parameters[i] === "string"
like on line 49 of Console.js?

I kind of feel using Object.type is an overkill for detecting string.


More information about the webkit-reviews mailing list