[webkit-reviews] review requested: [Bug 19954] Element with -webkit-mask: -webkit-canvas() is not redrawn when the canvas updates : [Attachment 22191] Patch addressing review comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 9 15:40:25 PDT 2008
Simon Fraser <simon.fraser at apple.com> has asked for review:
Bug 19954: Element with -webkit-mask: -webkit-canvas() is not redrawn when the
canvas updates
https://bugs.webkit.org/show_bug.cgi?id=19954
Attachment 22191: Patch addressing review comments
https://bugs.webkit.org/attachment.cgi?id=22191&action=edit
------- Additional Comments from Simon Fraser <simon.fraser at apple.com>
> (1) Adding maskBoxImage to RenderBox's first check is good.
I didn't add that, I just unwrapped the line.
> (2) Adding maskImage is bad. We want precise invalidation like we have with
> backgrounds. See the layer walk at the end of the function. You should make
a
> little static helper function that walks layers to do the invalidation. Then
> you can call it on the background layers and on the mask layers.
Done. Note that I had to add FillLayer::containsWrappedImage().
I added a method, repaintLayerRectsForImage(), rather than a static method,
because
it needs to get at the view() for invalidation.
> (2) The patch to RenderImage should just call the base class if you have a
> mask. So changing if (hasBoxDecorations()) to if (hasBoxDecorations() ||
> hasMask()) should be sufficient.
Done.
More information about the webkit-reviews
mailing list