[webkit-reviews] review denied: [Bug 19954] Element with -webkit-mask: -webkit-canvas() is not redrawn when the canvas updates : [Attachment 22167] Patch to repaint() when the mask image changes

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Simon Fraser <simon.fraser at apple.com>'s
request for review:
Bug 19954: Element with -webkit-mask: -webkit-canvas() is not redrawn when the
canvas updates
https://bugs.webkit.org/show_bug.cgi?id=19954

Attachment 22167: Patch to repaint() when the mask image changes
https://bugs.webkit.org/attachment.cgi?id=22167&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
(1) Adding maskBoxImage to RenderBox's first check is good.

(2) Adding maskImage is bad.  We want precise invalidation like we have  with
backgrounds.  See the layer walk at the end of the function.  You should make a
little static helper function that walks layers to do the invalidation.  Then
you can call it on the background layers and on the mask layers.

(2) The patch to RenderImage should just call the base class if you have a
mask.  So changing if (hasBoxDecorations()) to if (hasBoxDecorations() ||
hasMask()) should be sufficient.