[webkit-reviews] review denied: [Bug 19931] Input should be printed before the output in the console : [Attachment 22148] initial prototype

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19931: Input should be printed before the output in the console
https://bugs.webkit.org/show_bug.cgi?id=19931

Attachment 22148: initial prototype
https://bugs.webkit.org/attachment.cgi?id=22148&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+	 Fix for https://bugs.webkit.org/show_bug.cgi?id=19931

We usually include the title of the bug, then the URL, like this:

Fix Bug 19931: Input should be printed before the output in the console

<https://bugs.webkit.org/show_bug.cgi?id=19931>

+	 * page/inspector/Console.js: Console command line input gets printed
immediately.

We normally try to describe the actual changes made here, not what the problem
was that inspired the changes. We also try to break up the changes by function,
like this:

(WebInspector.Console.prototype._enterKeyPressed): Split the input/output into
two pieces. The input is added to the console before it is evaluated. After
evaluation the output is added.

+WebInspector.ConsoleCommandResult = function(command, result,
formattedResultElement, level)
+{
+    this.command = command;

I don't think we need to pass in and store the command here.

I think ConsoleCommandInput and ConsoleCommandOutput would be better names fro
these types than ConsoleCommand and ConsoleCommandResult. What do you think?

I guess there's a chance that some styling will change as a result of this, but
it looks like the common cases stay the same.

r- so that the ChangeLog can be fixed up and the new names can be considered.
Looking good!