[webkit-reviews] review granted: [Bug 19907] REGRESSION(r34824-r34941): Reproducible crash trying to log in to MediaTemple.net Account Center : [Attachment 22142] Revised proposed patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 19907: REGRESSION(r34824-r34941): Reproducible crash trying to log in to
MediaTemple.net Account Center
https://bugs.webkit.org/show_bug.cgi?id=19907

Attachment 22142: Revised proposed patch
https://bugs.webkit.org/attachment.cgi?id=22142&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Cameron mentioned on IRC that he would file a separate bug to address Mark's
comment.

I think the ChangeLog could be a little clearer. i would say something like,
"Clear the exception after invoking an NPAPI callback, to prevent it from
short-circuiting the next script that executes. FIXME: Find a way to return
this exception information through the NPAPI. See http..."