[webkit-reviews] review denied: [Bug 19762] Crash in svg/webarchive/svg-cursor-subresources.svg : [Attachment 22100] Different check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 6 19:50:16 PDT 2008

Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 19762: Crash in svg/webarchive/svg-cursor-subresources.svg

Attachment 22100: Different check

------- Additional Comments from Darin Adler <darin at apple.com>
This is unnecessarily fragile. While it's true that a document can reach the
state where its true refCount is 0 and the only references keeping it a live
are the self-only references from its children, it's not at all guaranteed that
this state corresponds with the case you care about here. I know you're looking
for "the right check" to detect this bad situation, and sadly this is not the

I'd like to understand exactly what makes the document "bad to work with" here.
Then I can help you figure out the right way to code it.

More information about the webkit-reviews mailing list