[webkit-reviews] review granted: [Bug 13067] Manually adding #hash to URL reloads entire page instead of jumping to #hash location in cached page : [Attachment 22108] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 13067: Manually adding #hash to URL reloads entire page instead of jumping
to #hash location in cached page
https://bugs.webkit.org/show_bug.cgi?id=13067

Attachment 22108: Patch v1
https://bugs.webkit.org/attachment.cgi?id=22108&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
	 checkNavigationPolicy(request, oldDocumentLoader.get(), formState,
-	     callContinueFragmentScrollAfterNavigationPolicy, this);
+			       callContinueFragmentScrollAfterNavigationPolicy,
this);

I don't personally consider this indentation change an improvement. It's a
change from a form that can be done with a simple editor to a form that
requires careful indenting or a syntax-sensitive editor (like emacs).

+    // These rules are based on what KHTML was doing in KHTMLPart::openURL.

I think this comment should either go away or change its wording to "were
originally based on".

+	 bool shouldScrollToAnchor(bool isFormSubmission, FrameLoadType
newLoadType, const KURL& newURL);

I'm not sure the "new" prefix alone is enough to justify giving the argument
names here.

r=me