[webkit-reviews] review denied: [Bug 19902] [XBL] We need to check nodes for content errors : [Attachment 22096] Add a boolean flag and per tag check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 6 18:04:52 PDT 2008


Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 19902: [XBL] We need to check nodes for content errors
https://bugs.webkit.org/show_bug.cgi?id=19902

Attachment 22096: Add a boolean flag and per tag check
https://bugs.webkit.org/attachment.cgi?id=22096&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not sure addChild is the correct place to check.  childrenChanged on
XBLElement is probably a better place.

Either way, error checking and propagation isn't a required to get simple
things up and running.	I suggest you ask hyatt where the correct place to put
this type of checking is... or we just deal with it later when we're further
along.


More information about the webkit-reviews mailing list