[webkit-reviews] review requested: [Bug 19762] Crash in svg/webarchive/svg-cursor-subresources.svg : [Attachment 22100] Different check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 5 11:50:53 PDT 2008


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 19762: Crash in svg/webarchive/svg-cursor-subresources.svg
https://bugs.webkit.org/show_bug.cgi?id=19762

Attachment 22100: Different check
https://bugs.webkit.org/attachment.cgi?id=22100&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This is the best check for checking whether the document is still valid I can
come up with. I started with document()->renderer() but AFAIK the code should
work too when the document has no renderer. A different approach would be to
clear the whole element id map before calling removeAllChildren, but I am not
sure if that would be right.
Cheers,

Rob.


More information about the webkit-reviews mailing list