[webkit-reviews] review denied: [Bug 19835] WebKit needs cross-platform filter system : [Attachment 22092] Trying again with the last 5
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jul 5 01:36:18 PDT 2008
Oliver Hunt <oliver at apple.com> has denied 's request for review:
Bug 19835: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19835
Attachment 22092: Trying again with the last 5
https://bugs.webkit.org/attachment.cgi?id=22092&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
A few issues i've noticed in this run through:
SVGFEFloodElement::build
* nonConstThis is not necessary as build() is not a const method.
* You removed the deref of the style objects, why? This will result in a leak
afaik
Alex, I'm r-'ing pending your response; if i feel the needed changes are
minimal after that i'll do them and land myself (unless of course you have a
new patch up already at that point)
More information about the webkit-reviews
mailing list