[webkit-reviews] review granted: [Bug 19888] Implement _NPN_SetException() correctly : [Attachment 22089] Revised cleanup patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 4 15:19:50 PDT 2008
Eric Seidel <eric at webkit.org> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 19888: Implement _NPN_SetException() correctly
https://bugs.webkit.org/show_bug.cgi?id=19888
Attachment 22089: Revised cleanup patch
https://bugs.webkit.org/attachment.cgi?id=22089&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.
Took me a minute to figure out what
_NPN_GetStringIdentifier
and
_NPN_GetStringIdentifiers were doing. I'm not sure the old argument names were
very helpful, but the names of those functions certainly aren't.
More information about the webkit-reviews
mailing list