[webkit-reviews] review requested: [Bug 19855] [GTK] Track sub frame life cycle : [Attachment 22042] Add signals to track the life cycle of sub frames

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 2 08:19:05 PDT 2008

Marco Barisione <marco.barisione at collabora.co.uk> has asked  for review:
Bug 19855: [GTK] Track sub frame life cycle

Attachment 22042: Add signals to track the life cycle of sub frames

------- Additional Comments from Marco Barisione
<marco.barisione at collabora.co.uk>
This patch adds a "new-web-frame" signal to WebKitWebView and a
"detached-from-web-view" signal to WebKitWebFrame.

Note that detached-from-web-view is never emitted for the main frame, so I
wonder if it's better to change the name of the signals making clear that they
are only for sub-frames or if it's better to emit "detached-from-web-view" also
when the main frame is going to be destroyed. In the latter case
"new-web-frame" will not be useful for the main frame as this frame is created
at the same time of the web view, so before being able to connect signal

Note that this patch breaks ABI adding a virtual function to WebKitWebView, if
we want to commit it before an ABI break I can split the patch and add the
function pointer only later.

If the patch is ok I will remove the test code from main.c, add documentation
and the ChangeLog entry.

More information about the webkit-reviews mailing list