[webkit-reviews] review denied: [Bug 19835] WebKit needs cross-platform filter system : [Attachment 22038] Rename SVGFEBlend class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 1 23:26:44 PDT 2008

Oliver Hunt <oliver at apple.com> has denied 's request for review:
Bug 19835: WebKit needs cross-platform filter system

Attachment 22038: Rename SVGFEBlend class

------- Additional Comments from Oliver Hunt <oliver at apple.com>
You should probably make "SVGFEBlendElement::filterEffect" etc
return 0;

In general comments about future work shouldn't be present unless they're
FIXME's (ideally with bug#'s).	In cases like this where you expect to remove
the code in the near future an ASSERT_NOT_REACHED is sensible.

Is the change to WebCore/svg/SVGFilterPrimitiveStandardAttributes.h really

More information about the webkit-reviews mailing list