[webkit-reviews] review denied: [Bug 19835] WebKit needs cross-platform filter system : [Attachment 22032] First few new files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 1 14:39:59 PDT 2008


Oliver Hunt <oliver at apple.com> has denied 's request for review:
Bug 19835: WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19835

Attachment 22032: First few new files
https://bugs.webkit.org/attachment.cgi?id=22032&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
After some thought i think you should put the Filter and FilterEffect
constructors and create methods into appropriate C++ files, as this matches our
style in other similar cases, and may be beneficial as the classes get more
complete.

Otherwise this looks great!


More information about the webkit-reviews mailing list