[webkit-reviews] review granted: [Bug 17130] Stop Windows from eating crashes in timer callbacks : [Attachment 18839] Move to SharedTimerWin.cpp impl. to fix callback problem

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 17130: Stop Windows from eating crashes in timer callbacks
http://bugs.webkit.org/show_bug.cgi?id=17130

Attachment 18839: Move to SharedTimerWin.cpp impl. to fix callback problem
http://bugs.webkit.org/attachment.cgi?id=18839&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
 #include "Page.h"
+#if PLATFORM(WIN)
 #include "PluginViewWin.h"
+#endif
 #include "SystemTime.h"
 #include "Widget.h"
 #include <wtf/Assertions.h>
+#if PLATFORM(WX)
+#include <wx/wx.h>
+#endif
 #include <windows.h>

Please put any #ifdef'd headers in their own paragraph after all the
non-#ifdef'd headers. That's the style we use in most files like this.

+
 namespace WebCore {

This extra newline isn't needed.

r=me, even if these issues aren't fixed. It would be nice to fix these before
committing though.