[webkit-reviews] review requested: [Bug 14270] Impossible to close web inspector when docked to webview : [Attachment 18795] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 30 11:50:02 PST 2008


Matt Lilek <webkit at mattlilek.com> has asked  for review:
Bug 14270: Impossible to close web inspector when docked to webview
http://bugs.webkit.org/show_bug.cgi?id=14270

Attachment 18795: patch
http://bugs.webkit.org/attachment.cgi?id=18795&action=edit

------- Additional Comments from Matt Lilek <webkit at mattlilek.com>
Add a close button to the toolbar when the inspector is docked.  After the
inspector is closed this way, it reopens docked. I think that makes the most
sense but I'd be more than happy to listen to reasons for why it should be
another way.

The images used for the close button are from Drosera, renamed and converted to
pngs to match the rest of the inspector's images.

Build fix stubs of the new client method for non-mac/win platforms are not
included in this patch, but I have them locally.


More information about the webkit-reviews mailing list