[webkit-reviews] review requested: [Bug 17017] Remove KJS::UChar : [Attachment 18754] Combined patch for darin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 19:01:13 PST 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 17017: Remove KJS::UChar
http://bugs.webkit.org/show_bug.cgi?id=17017

Attachment 18754: Combined patch for darin
http://bugs.webkit.org/attachment.cgi?id=18754&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 JavaScriptCore/API/JSStringRef.cpp	      |    8 ++--
 JavaScriptCore/API/JSStringRefCF.cpp	      |    2 +-
 JavaScriptCore/JavaScriptCore.exp	      |   10 ++--
 JavaScriptCore/bindings/c/c_utility.cpp      |    2 +-
 JavaScriptCore/bindings/objc/objc_utility.mm |    2 +-
 JavaScriptCore/kjs/Parser.h		      |    2 -
 JavaScriptCore/kjs/function.cpp	      |   32 +++++++-------
 JavaScriptCore/kjs/function_object.cpp       |    4 +-
 JavaScriptCore/kjs/identifier.cpp	      |    8 ++--
 JavaScriptCore/kjs/interpreter.h	      |    2 -
 JavaScriptCore/kjs/lexer.cpp		      |   29 ++++++------
 JavaScriptCore/kjs/lookup.cpp		      |    2 +-
 JavaScriptCore/kjs/nodes2string.cpp	      |    5 +-
 JavaScriptCore/kjs/string_object.cpp	      |   14 +++---
 JavaScriptCore/kjs/ustring.cpp 	      |   40 ++++++++--------
 JavaScriptCore/kjs/ustring.h		      |   62 +-------------------------
 WebCore/bindings/js/kjs_proxy.cpp	      |    2 +-
 WebCore/bindings/js/kjs_window.cpp	      |    4 +-
 WebCore/dom/Document.cpp		      |    4 +-
 WebCore/html/HTMLFormElement.cpp	      |    2 +-
 WebCore/platform/DeprecatedString.cpp	      |    4 +-
 WebCore/platform/text/AtomicString.cpp       |    4 +-
 WebCore/platform/text/String.cpp	      |    8 ++--
 WebCore/platform/text/TextCodecICU.cpp       |    2 +-
 24 files changed, 97 insertions(+), 157 deletions(-)


More information about the webkit-reviews mailing list