[webkit-reviews] review granted: [Bug 16980] Support external SVG Fonts : [Attachment 18742] Final patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 28 15:05:24 PST 2008

Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 16980: Support external SVG Fonts

Attachment 18742: Final patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok, this looks great.  We talked about making getSVGFontById actually return an
SVGFontElement (I think you've already done that locally).

I also think that we need some http tests for external fonts.  We could just
file another bug about those, but it would be nice to land one or two via this
patch.	Things to test:

1.  When a font is sent with the wrong mime type, do we handle it? (we
currently ignore the mimetype and parse it anyway)
2.  When the font has a 404 doe we use it anyway (currently we have this bug
throughout other parts of WebKit, it's OK not to fix this, but we should at
least file a bug about it).
3.  If the font has an XML parse error what happens?  If the error is
encountered after the <font> declaration, do we still treat the font as valid? 
(I believe we do with your current code).

Those 3 need at least bugs, and preferably test cases.

Otherwise this looks totally ready to go.

More information about the webkit-reviews mailing list