[webkit-reviews] review denied: [Bug 17030] Small buffer overflow within initialization : [Attachment 18723] Same as in original post

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 27 12:05:14 PST 2008


Alexey Proskuryakov <ap at webkit.org> has denied Stephan Binner
<stbinner at suse.de>'s request for review:
Bug 17030: Small buffer overflow within initialization
http://bugs.webkit.org/show_bug.cgi?id=17030

Attachment 18723: Same as in original post
http://bugs.webkit.org/attachment.cgi?id=18723&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Instead of correcting memset usage, we should just remove it (not just here,
but all the instances that were mistakenly used for GregorianDateTime
initialization).

Also, the patch needs a change log.


More information about the webkit-reviews mailing list