[webkit-reviews] review denied: [Bug 16981] Thai word break support : [Attachment 18616] Patch to enable Thai wordbreaking in WebKit

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Pattara Kiatisevi <pattara at mm.co.th>'s
request for review:
Bug 16981: Thai word break support
http://bugs.webkit.org/show_bug.cgi?id=16981

Attachment 18616: Patch to enable Thai wordbreaking in WebKit
http://bugs.webkit.org/attachment.cgi?id=18616&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
First, let me thank you VERY MUCH for taking the time to contribute to WebKit. 
We strongly value new contributions, and I would like to encourage you to
contribute more in the future.

That said, we're not going to take this patch.	More information below:


Ok, so it looks like ICU does support Thai breaking.  Safari 3.0.4 on Mac OS X
already gets this test case correct:
http://www.mm.co.th/~pattara/thai/wbrtest-short.html
(as far as I can tell)

So this bug only applies to platforms which are not able to use ICU.  Both
WebKitWinApple and WebKitMac use ICU.  I'm not certain about WebKitGtk or
WebKitQt.

In order for this bug to move forward, we would need an example of a platform
combination under active development which did not support proper Thai word
breaks.

In that case, we would need to re-write this patch to apply to the TextIterator
platform abstraction model (which looks to be possible.

This patch has a raft of style issues, as previously mentioned, as well as
memory leaks (the entire thai cached leaks).

I'm marking this r-, and I recommend with close the bug as "INVALID" unless we
can come up with a paltform combination which doesn't already have thai word
break support.