[webkit-reviews] review denied: [Bug 16881] [GTK] PlatformScreenGtk is unimplemented : [Attachment 18525] Implement stubs, updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 26 08:43:07 PST 2008

Darin Adler <darin at apple.com> has denied Christian Dywan
<christian at imendio.com>'s request for review:
Bug 16881: [GTK] PlatformScreenGtk is unimplemented

Attachment 18525: Implement stubs, updated

------- Additional Comments from Darin Adler <darin at apple.com>
 73	return IntRect(0, 0, gdk_screen_get_width(screen),

This doesn't look right for when multiple screens are involved. This is
supposed to return the proper rectangle considering a single large coordinate
space -- it can't have an origin of 0,0 for every screen. Did you test this?

More information about the webkit-reviews mailing list