[webkit-reviews] review denied: [Bug 16994] SmartReplace.cpp isn't implemented for platforms without CoreFoundation : [Attachment 18638] implement WebCore::isCharacterSmartReplaceExempt

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied idealisms at gmail.com's request for
review:
Bug 16994: SmartReplace.cpp isn't implemented for platforms without
CoreFoundation
http://bugs.webkit.org/show_bug.cgi?id=16994

Attachment 18638: implement WebCore::isCharacterSmartReplaceExempt
http://bugs.webkit.org/attachment.cgi?id=18638&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Code looks fine, but it's not platform-independent since it uses ICU; not all
ports of WebCore have ICU, and it's not acceptable to just have ICU code
without any ifdefs. It should go into a file named SmartReplaceICU.cpp and be
properly ifdef'd. Otherwise, fine.

+	 // Nice to have, added in ICU 3.8.
+	 //uset_freeze(smartSet);

This can be ifdef'd based on the ICU headers. It would be better to either
include it for real or not. We don't normally include commented out code.

The if is "#if USE (ICU_UNICODE)" I believe. You should look for an example.