[webkit-reviews] review granted: [Bug 16618] [GTK] build-webkit and
run-webkit-tests autootools support : [Attachment 18576]
updated patch to cleanup feature flags
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 26 03:00:51 PST 2008
Mark Rowe (bdash) <mrowe at apple.com> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 16618: [GTK] build-webkit and run-webkit-tests autootools support
http://bugs.webkit.org/show_bug.cgi?id=16618
Attachment 18576: updated patch to cleanup feature flags
http://bugs.webkit.org/attachment.cgi?id=18576&action=edit
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Looks good to me.
+ my @buildArgs = {"CONFIG+=gtk-port"};
+ push @buildArgs, "CONFIG-=qt";
This feels a little bit inconsistent, but I guess it's not really a big deal.
More information about the webkit-reviews
mailing list