[webkit-reviews] review granted: [Bug 16954] Support putImageData : [Attachment 18618] A hopefully "complete" patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 24 00:08:05 PST 2008

Eric Seidel <eric at webkit.org> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 16954: Support putImageData

Attachment 18618: A hopefully "complete" patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think this looks fine.

I would suggest replacing:
// Accursed flipped y axis
with a more useful comment, perhaps:
// CG flips the y-axis, so we unflip it here

 [Custom] void putImageData(/* 3 */);
should have real argument names, even if the other functions in that section
don't. :p

These could be re-written as simpler statements using std:min:
1040	int endX = dest.x() + data.m_width;
1041	if (endX > m_canvas->width())
1042	    endX = m_canvas->width();

We really should have a test case which demonstrates the "convert any exception
to a TypeError exception" behavior.

Otherwise it's fine.

More information about the webkit-reviews mailing list