[webkit-reviews] review requested: [Bug 16924] Shared PluginDatabase, PluginPackage, and PlugInInfoStore Implementations : [Attachment 18604] Updated patch to fix issues

[bugzilla-daemon at webkit.org]

Rodney Dawes <dobey at wayofthemonkey.com> has asked  for review:
Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore
Implementations
http://bugs.webkit.org/show_bug.cgi?id=16924

Attachment 18604: Updated patch to fix issues
http://bugs.webkit.org/attachment.cgi?id=18604&action=edit

------- Additional Comments from Rodney Dawes <dobey at wayofthemonkey.com>
This patch resolves the issues presented by Mark in review of the previous
version.

As for the FileSystem concern, it is probably the wrong name for the file, as
none of the operations in it are actually filesystem-dependent. They are file
operations, not filesystem operations. A module is a special type of file. I
think  the method to unload it in a platform-independent way belongs in the
same place as closing a normal file in a platform-independent way.