[webkit-reviews] review denied: [Bug 16250] Implement Element.all
(http://news.vnet.cn : Mouse hover on tabs not working) :
[Attachment 18557] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 21 23:39:55 PST 2008
Eric Seidel <eric at webkit.org> has denied David Smith <catfish.man at gmail.com>'s
request for review:
Bug 16250: Implement Element.all (http://news.vnet.cn : Mouse hover on tabs not
working)
http://bugs.webkit.org/show_bug.cgi?id=16250
Attachment 18557: Patch
http://bugs.webkit.org/attachment.cgi?id=18557&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
So I think this patch is fine. The only thing missing is test cases. :)
r- until we add at least one element.all test case! :) The test that it's
undetectable is nice, but doesn't really test the feature. :)
More information about the webkit-reviews
mailing list