[webkit-reviews] review granted: [Bug 16955] Get errors when cross-compile webkit-gtk : [Attachment 18575] patch to cleanup ICU_CFLAGS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 15:06:38 PST 2008


Alp Toker <alp at atoker.com> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 16955: Get errors when cross-compile webkit-gtk
http://bugs.webkit.org/show_bug.cgi?id=16955

Attachment 18575: patch to cleanup ICU_CFLAGS
http://bugs.webkit.org/attachment.cgi?id=18575&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
ICU libs/cflags only need to be added to jsc and webcore, nothing else. There
are also other redundant flags we can remove.

Also found tabs in WebKitTools/ChangeLog

Will fix up these issues.


More information about the webkit-reviews mailing list