[webkit-reviews] review requested: [Bug 16500] [GTK] comments link = page not found : [Attachment 18541] Don't send the URL fragment part to the server

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 19 05:35:11 PST 2008


Alp Toker <alp at atoker.com> has asked  for review:
Bug 16500: [GTK] comments link = page not found
http://bugs.webkit.org/show_bug.cgi?id=16500

Attachment 18541: Don't send the URL fragment part to the server
http://bugs.webkit.org/attachment.cgi?id=18541&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
This fixes the known issues.

+    url = url.left(url.find('#'));

Hopefully someone who knows their HTTP can review this patch.

Is my fix robust ie. will the first '#' encountered always denote a URI
fragment? Is there a better way to get the URL without the fragment using the
KURL class rather than doing a string search?


More information about the webkit-reviews mailing list