[webkit-reviews] review granted: [Bug 14846] Layout is not updated when table padding is changed through JavaScript : [Attachment 18483] Make sure to mark cells for layout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 16 13:50:13 PST 2008


Eric Seidel <eric at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 14846: Layout is not updated when table padding is changed through
JavaScript
http://bugs.webkit.org/show_bug.cgi?id=14846

Attachment 18483: Make sure to mark cells for layout
http://bugs.webkit.org/attachment.cgi?id=18483&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the fix is great.  Personally I find the name
RenderTable:setCellPadding to promote more of  (at least my) historical
confusion as to whether it is correct to push attribute changes from the DOM to
the Renderer (incorrect) or whether it's right to just mark renderers as
needing layout and pull changes from the Renderers from the DOM (correct, and
this change does that... in the cells).

Anyway.  Looks fine.


More information about the webkit-reviews mailing list